java org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl@779de014 已关闭

org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl@779de014 is closed

提问by John

I am trying to create or update user with Hibernate 5 and it throws following exception: org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl@779de014 is closed

我正在尝试使用 Hibernate 5 创建或更新用户，它抛出以下异常：org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl@779de014 is closed

I'm using the following technologies:

我正在使用以下技术：

• Spring 4
• Hibernate 5
• Maven
• Eclipse

• 春天 4
• 休眠 5
• 马文
• 蚀

This is my UserDaoImpl.Java:

这是我的UserDaoImpl.Java：

package com.fasttrack.users.dao;
import java.util.List;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Repository;
import org.springframework.transaction.annotation.Transactional;
import com.fasttrack.users.model.User;

@Repository
@Transactional
public class UserDaoImpl extends AbstractDao implements UserDao
{
    @Autowired
    private SessionFactory sessionFactory;
    public boolean saveUser(User user)
    {
         Session session=sessionFactory.getCurrentSession();
          try
          {
             session.persist(user);
             return true;
          }

          catch (Exception e) 
          {

            e.printStackTrace();
            return false;
        }

          finally 
          {
              session.close(); 
           }

    }


    @SuppressWarnings("unchecked")
    public List<User> getUsers()
    {
         List<User> users;
         Session session=sessionFactory.getCurrentSession();
          try
          {
              users=(List<User>) session.createQuery("FROM USER"); 
              return users;
          }

          catch (Exception e) 
          {
            e.printStackTrace();
        }

          finally {
              session.close(); 
           }
        return null;
    }

    public User getUser(String id)
    {
         User user;
         Session session=sessionFactory.getCurrentSession();
          try
          {
              user=(User)session.get(User.class,id); 
              return user;
          }

          catch (Exception e) 
          {
            e.printStackTrace();
            return null;
        }

          finally 
          {
              session.close(); 
           }

    }



    public boolean updateUser(User user)
    {
        Session session = sessionFactory.getCurrentSession();
        try
            {
                session.saveOrUpdate(user);
                return true;
            }

        catch (Exception e)
            {
                e.printStackTrace();
                return false;
            }

        finally
            {
                session.close();
            }
    }


    public boolean deleteUserById(String id)
    {
        User user = new User();
        user.setId(id);

        Session session = sessionFactory.getCurrentSession();
        try
            {
                session.delete(user);
                return true;
            }

        catch (Exception e)
            {
                e.printStackTrace();
                return false;
            }

        finally
            {
                session.close();
            }
    }

}

This is my TestUserDao.java:

这是我的TestUserDao.java：

import com.fasttrack.users.dao.UserDao;
import com.fasttrack.users.model.User;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;


@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration("/Hibernate-test.xml")

public class TestUserDao
{
    @Autowired(required=true)
    public UserDao userDao;

    @Test
    public void testSaveUser()
    {
        User user=new User();
        user.setFirstName("TestUser1");
        boolean result=userDao.saveUser(user);
    }
}

Error Message:

错误信息：

Mar 01, 2017 1:14:52 PM org.springframework.test.context.support.DefaultTestContextBootstrapper getDefaultTestExecutionListenerClassNames
INFO: Loaded default TestExecutionListener class names from location [META-INF/spring.factories]: [org.springframework.test.context.web.ServletTestExecutionListener, org.springframework.test.context.support.DirtiesContextBeforeModesTestExecutionListener, org.springframework.test.context.support.DependencyInjectionTestExecutionListener, org.springframework.test.context.support.DirtiesContextTestExecutionListener, org.springframework.test.context.transaction.TransactionalTestExecutionListener, org.springframework.test.context.jdbc.SqlScriptsTestExecutionListener]
Mar 01, 2017 1:14:52 PM org.springframework.test.context.support.DefaultTestContextBootstrapper getTestExecutionListeners
INFO: Using TestExecutionListeners: [org.springframework.test.context.web.ServletTestExecutionListener@6be46e8f, org.springframework.test.context.support.DirtiesContextBeforeModesTestExecutionListener@3567135c, org.springframework.test.context.support.DependencyInjectionTestExecutionListener@327471b5, org.springframework.test.context.support.DirtiesContextTestExecutionListener@4157f54e, org.springframework.test.context.transaction.TransactionalTestExecutionListener@90f6bfd, org.springframework.test.context.jdbc.SqlScriptsTestExecutionListener@47f6473]
Mar 01, 2017 1:14:52 PM org.springframework.beans.factory.xml.XmlBeanDefinitionReader loadBeanDefinitions
INFO: Loading XML bean definitions from class path resource [Hibernate-test.xml]
Mar 01, 2017 1:14:53 PM org.springframework.context.support.GenericApplicationContext prepareRefresh
INFO: Refreshing org.springframework.context.support.GenericApplicationContext@2a5ca609: startup date [Wed Mar 01 13:14:53 EST 2017]; root of context hierarchy
Mar 01, 2017 1:14:53 PM org.springframework.context.support.PropertySourcesPlaceholderConfigurer loadProperties
INFO: Loading properties file from class path resource [database.properties]
Mar 01, 2017 1:14:53 PM org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor <init>
INFO: JSR-330 'javax.inject.Inject' annotation found and supported for autowiring
Mar 01, 2017 1:14:53 PM org.hibernate.Version logVersion
INFO: HHH000412: Hibernate Core {5.2.6.Final}
Mar 01, 2017 1:14:53 PM org.hibernate.cfg.Environment <clinit>
INFO: HHH000206: hibernate.properties not found
Mar 01, 2017 1:14:53 PM org.hibernate.annotations.common.reflection.java.JavaReflectionManager <clinit>
INFO: HCANN000001: Hibernate Commons Annotations {5.0.1.Final}
Mar 01, 2017 1:14:54 PM org.hibernate.dialect.Dialect <init>
INFO: HHH000400: Using dialect: org.hibernate.dialect.MySQLDialect
Mar 01, 2017 1:14:54 PM org.hibernate.engine.jdbc.env.internal.LobCreatorBuilderImpl useContextualLobCreation
INFO: HHH000423: Disabling contextual LOB creation as JDBC driver reported JDBC version [3] less than 4
Mar 01, 2017 1:14:54 PM org.springframework.orm.hibernate5.HibernateTransactionManager afterPropertiesSet
INFO: Using DataSource [org.apache.commons.dbcp.BasicDataSource@130d63be] of Hibernate SessionFactory for HibernateTransactionManager
Generated Id: USER0
Mar 01, 2017 1:14:55 PM org.springframework.orm.hibernate5.HibernateTransactionManager doRollbackOnCommitException
SEVERE: Commit exception overridden by rollback exception
java.lang.IllegalStateException: org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl@6b410923 is closed
    at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.errorIfClosed(AbstractLogicalConnectionImplementor.java:37)
    at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.getPhysicalConnection(LogicalConnectionManagedImpl.java:128)
    at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.getConnectionForTransactionManagement(LogicalConnectionManagedImpl.java:247)
    at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.commit(AbstractLogicalConnectionImplementor.java:79)
    at org.hibernate.resource.transaction.backend.jdbc.internal.JdbcResourceLocalTransactionCoordinatorImpl$TransactionDriverControlImpl.commit(JdbcResourceLocalTransactionCoordinatorImpl.java:221)
    at org.hibernate.engine.transaction.internal.TransactionImpl.commit(TransactionImpl.java:68)
    at org.springframework.orm.hibernate5.HibernateTransactionManager.doCommit(HibernateTransactionManager.java:582)
    at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:761)
    at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:730)
    at org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:504)
    at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:292)
    at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
    at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:213)
    at com.sun.proxy.$Proxy31.saveUser(Unknown Source)
    at TestUserDao.testSaveUser(TestUserDao.java:23)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
    at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
    at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
    at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:context="http://www.springframework.org/schema/context"
        xmlns:tx="http://www.springframework.org/schema/tx"
        xmlns:aop="http://www.springframework.org/schema/aop"
        xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.0.xsd
                            http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-4.0.xsd
                            http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-4.0.xsd
                            http://www.springframework.org/schema/tx  http://www.springframework.org/schema/tx/spring-tx-4.0.xsd">


    <context:property-placeholder location="classpath:database.properties" />
      <context:component-scan  base-package="com.timelee.*" />


    <tx:annotation-driven transaction-manager="transactionManager"/>


     <!--  <bean id="dataSource" class="org.springframework.jdbc.datasource.DriverManagerDataSource">  -->

     <bean id="dataSource" destroy-method="close" class="org.apache.commons.dbcp.BasicDataSource">
       <property name="driverClassName" value="${jdbc.driverClassName}" />
        <property name="url" value="${jdbc.url}"/>
        <property name="username" value="${jdbc.username}" />
        <property name="password" value="${jdbc.password}"/>

    </bean>



    <bean id="sessionFactory" class="org.springframework.orm.hibernate5.LocalSessionFactoryBean" >
        <property name="dataSource" ref="dataSource"/>
        <property name="packagesToScan">
            <list>
                <value>com.timelee.timesheet.model</value>
                <value>com.timelee.users.model</value>
                <value>com.timelee.*</value>
            </list>
        </property>
        <property name="hibernateProperties">
            <props>
                <prop key="hibernate.dialect">${hibernate.dialect}</prop>
                <prop key="hibernate.show_sql">${hibernate.show_sql:false}</prop>
                <prop key="hibernate.format_sql">${hibernate.format_sql:false}</prop>
                <prop key="hibernate.hbm2ddl.auto">update</prop>
            </props>
        </property>       
    </bean>

    <bean id="transactionManager"  class="org.springframework.orm.hibernate5.HibernateTransactionManager">
        <property name="sessionFactory" ref="sessionFactory" />
    </bean>

    <bean id="persistenceExceptionTranslationPostProcessor"
        class="org.springframework.dao.annotation.PersistenceExceptionTranslationPostProcessor"/>

</beans>
0(ParentRunner.java:58)
    at org.junit.runners.ParentRunner.evaluate(ParentRunner.java:268)
    at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
    at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)

Hibernate xml file:

休眠xml文件：

apiCall
  -> @Transactional 
     doSomethingWithConnectionA
     -> @Transactional
        doSomethingWithConnectionB

回答by John

I found something strange in your error message "SEVERE: Commit exception overridden by rollback exception". If you look at the try block in UserDaoImpl.Javafile you have return statement, which closes the hibernate connection before returning. And you have session.close()statement in finally block which doesn't make sense, since the connection was already closed. Would you mind removing session.close()statement and try again. Let me know if this solves your problem.

我在您的错误消息“严重：提交异常被回滚异常覆盖”中发现了一些奇怪的东西。如果您查看UserDaoImpl.Java文件中的 try 块，您有 return 语句，它在返回之前关闭休眠连接。并且您session.close()在 finally 块中的声明没有意义，因为连接已经关闭。您介意删除session.close()语句并重试吗？如果这能解决您的问题，请告诉我。

回答by c_froehlich

I stumbled over a quite similar stack trace when updating a legacy application to Hibernate 5 / Spring 4 and implementing transaction support while I was at it.

在将遗留应用程序更新到 Hibernate 5 / Spring 4 并实现事务支持时，我偶然发现了一个非常相似的堆栈跟踪。

We are using two database connections (two SessionFactories and two TransactionManagers).

我们使用了两个数据库连接（两个 SessionFactories 和两个 TransactionManagers）。

The problem was that I nested a transaction on connection B inside a transaction on connection A. Like this:

问题是我将连接 B 上的事务嵌套在连接 A 上的事务中。像这样：

apiCall
  -> @Transactional 
     doSomethingWithConnectionA
  -> @Transactional
     doSomethingWithConnectionB

The issue was gone, when I excuted the functions one after the other from the same level

问题消失了，当我从同一级别一个接一个执行功能时

@SuppressWarnings("unchecked")
public List<User> getUsers() {
    List<User> users;
    Session session=sessionFactory.getCurrentSession();
    try
    {
        users=(List<User>) session.createQuery("FROM USER"); 
        return users;
    }
    catch (Exception e) 
    {
        e.printStackTrace();
    }
    finally {
      session.close(); 
    }
    return null;
}

回答by Vlad Mihalcea

As explained in the Spring Framework User Guide, in a @Transactionalblock, you don't need to manually manage the Hibernate Sessionsince the TransactionInterceptordoes that for you.

正如Spring Framework User Guide 中所解释的，在一个@Transactional块中，您不需要手动管理 Hibernate，Session因为TransactionInterceptor它会为您完成。

So, instead of:

所以，而不是：

@SuppressWarnings("unchecked")
public List<User> getUsers() {
    try {
        return sessionFactory.getCurrentSession()
        .createQuery("FROM USER")
        .getResultList(); 
    }
    catch (Exception e) {
        throw new RuntimeException(e);
    }
}

you should do this:

你应该做这个：

##代码##

Aside from removing the session.closecall, there were more issues that I fixed in your example:

除了删除session.close电话之外，我在您的示例中还修复了更多问题：

1. You were not calling getResultList()on the Hibernate Querywhich, instead, you cast to List<User>
2. Calling e..printStackTrace();is bad. You should use a Logger framework instead. In this case, it's better to propagate the exception further instead of hiding it under the carpet.
3. Why would you return nullwhen you expect a List? If there is no result, and empty Listis a much better alternative. In your example, when you got an exception, you'd return nullwhich it's indistinguishable from the case when you'd get an empty result set.

1. 您没有调用getResultList()Hibernate Query，相反，您将其转换为 List<User>
2. 打电话e..printStackTrace();不好。您应该改用 Logger 框架。在这种情况下，最好进一步传播异常而不是将其隐藏在地毯下。
3. null当您期望 a 时，您为什么要返回List？如果没有结果，空List是更好的选择。在您的示例中，当您遇到异常时，您将返回null它与获得空结果集的情况无法区分的情况。